fix setdiff(::IntSet, x) when x <= 0 #23191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
bugfix
Sacha0
reviewed
Aug 9, 2017
| @@ -143,7 +143,7 @@ function intersect!(s1::IntSet, s2::IntSet) | |||
| end | |||
|
|
|||
| setdiff(s::IntSet, ns) = setdiff!(copy(s), ns) | |||
| setdiff!(s::IntSet, ns) = (for n in ns; _delete!(s, n); end; s) | |||
| setdiff!(s::IntSet, ns) = (for n in ns; delete!(s, n); end; s) | |||
There was a problem hiding this comment.
IIUC, the cost of this change is an additional branch for each element in ns?
There was a problem hiding this comment.
Yes I think so, but it seems unavoidable since there's no way to know that everything in ns is safe in general.
There was a problem hiding this comment.
Perhaps some construct with an @boundscheck could provide an escape hatch?
There was a problem hiding this comment.
At least the optimized method (below) when ns is an IntSet remains unaffected. It would also be easy to have an unsafe_setdiff! if needed (till now, it seems @boundscheck is not used for this kind of usage?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.