REPL: transpose words with Alt-t #23378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* these allow to request the position past the end (at least for `String`); this is useful when working with `IOBuffer`, which has one more position than there are valid indexes in the corresponding `String`. * ind2chr becomes slightly faster as a result of removing one unnecessary `next` call * the main logic of these functions is factored out into one single function
7 tasks
Fixes part of #8447.
rfourquet
force-pushed
the
rf/REPL-transpose-words
branch
from
29cdc2c
to
5838d5a
Compare
StefanKarpinski
approved these changes
Aug 22, 2017
Oh that was so obvious? 😊 |
tkelman
reviewed
Aug 30, 2017
| edit_transpose_words(s) = edit_transpose_words(buffer(s)) && refresh_line(s) | ||
|
|
||
| function edit_transpose_words(buf::IOBuffer, mode=:emacs) | ||
| mode in [:readline, :emacs] || |
There was a problem hiding this comment.
would it be possible to describe what the difference in behavior is in words somewhere? this doesn't have a docstring, but a comment would do if anyone is going to be customizing these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.