RFC: evaluate for
iterator in outer scope
#23387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's scope season, here's another issue that, in a way, is the flip side of #22659.
Reasoning by the following transformation:
to
itr
should be evaluated in the surrounding scope. However, we currently enclose the entirefor
loop in a new scope, in addition to the per-iteration scope. I believe this is unnecessary.The breakage here is extremely minor, since for this to matter you basically have to write
for i in (a = b)
, which nobody ever does. Code that does do that is likely to keep working, since you can still seea
inside the loop.