-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop building and shipping openspecfun #23598
Conversation
@jlbuild !nuke
|
Okay, I'm not sure whether jlbuild is still up and running, but either way this works on CI using the binaries I built for it as well as locally on a system without binaries, so I guess the jlbuild run should be mostly unnecessary anyway. So this is good to go! |
Status of 569e757 builds:
|
Hmmm, so something is borked in
In any case, I'm going to kick the server over and see if that fixes anything. |
If you've kicked the server, should I try invoking jlbuild again? |
It looks like there are unrelated testing errors with the buildbots. :/ |
Unrelated here, but we had at some point discussed translating the openspecfun code to Julia using @nolta 's script. That might be worth visiting once this is split off and stabilized(but obviously some non-trivial work). |
At this point, this should be a non-functional change, since openspecfun isn't being used internally anymore as of #22603. It is technically breaking, however, since any code that was referencing
Base.Math.openspecfun
or explicitlyccall
ing into openspecfun will be broken.I'm marking this as WIP until I have binary downloading/building finished in SpecialFunctions. (It's close.) Once that's done I'll remove the "WIP."Ready. 😎Fixes #22390.