Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building and shipping openspecfun #23598

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Sep 6, 2017

At this point, this should be a non-functional change, since openspecfun isn't being used internally anymore as of #22603. It is technically breaking, however, since any code that was referencing Base.Math.openspecfun or explicitly ccalling into openspecfun will be broken.

I'm marking this as WIP until I have binary downloading/building finished in SpecialFunctions. (It's close.) Once that's done I'll remove the "WIP." Ready. 😎

Fixes #22390.

@ararslan ararslan added breaking This change will break code building Build system, or building Julia or its dependencies maths Mathematical functions labels Sep 6, 2017
@ararslan ararslan added this to the 1.0 milestone Sep 6, 2017
@ararslan
Copy link
Member Author

ararslan commented Sep 8, 2017

@jlbuild !nuke

Pkg.clone("https://github.com/JuliaMath/SpecialFunctions.jl.git")
Pkg.checkout("SpecialFunctions", "master")
Pkg.build("SpecialFunctions")
Pkg.test("SpecialFunctions")

@ararslan ararslan changed the title WIP: Stop building and shipping openspecfun Stop building and shipping openspecfun Sep 8, 2017
@ararslan
Copy link
Member Author

ararslan commented Sep 8, 2017

Okay, I'm not sure whether jlbuild is still up and running, but either way this works on CI using the binaries I built for it as well as locally on a system without binaries, so I guess the jlbuild run should be mostly unnecessary anyway.

So this is good to go!

@ararslan ararslan requested review from StefanKarpinski and staticfloat and removed request for StefanKarpinski September 8, 2017 23:05
@jlbuild
Copy link

jlbuild commented Sep 9, 2017

Status of 569e757 builds:

Builder Name Nuke Build Download Code Output
linux32 COMPLETE ERRORED N/A N/A
linux64 COMPLETE ERRORED N/A N/A
linuxaarch64 COMPLETE ERRORED N/A N/A
linuxarmv7l COMPLETE ERRORED N/A N/A
linuxppc64le PENDING N/A N/A N/A
osx64 COMPLETE COMPLETE Download PENDING
win32 PENDING N/A N/A N/A
win64 PENDING N/A N/A N/A

@JuliaLang JuliaLang deleted a comment from jlbuild Sep 9, 2017
@staticfloat
Copy link
Member

staticfloat commented Sep 9, 2017

Hmmm, so something is borked in jlbuild, I'm getting backtraces from HttpServer.jl:

app_1  | ERROR (unhandled task failure): write: broken pipe (EPIPE)
app_1  |  in yieldto(::Task, ::ANY) at ./event.jl:136
app_1  |  in wait() at ./event.jl:169
app_1  |  in stream_wait(::Task) at ./stream.jl:44
app_1  |  in uv_write(::TCPSocket, ::Ptr{UInt8}, ::UInt64) at ./stream.jl:820
app_1  |  in unsafe_write(::TCPSocket, ::Ptr{UInt8}, ::UInt64) at ./stream.jl:830
app_1  |  in write(::TCPSocket, ::Array{UInt8,1}) at ./io.jl:175
app_1  |  in write(::TCPSocket, ::HttpCommon.Response) at /root/.julia/v0.5/HttpServer/src/HttpServer.jl:182
app_1  |  in (::HttpServer.#on_message_complete#18{HttpServer.Server,HttpServer.Client{TCPSocket},Bool})(::HttpCommon.Request) at /root/.julia/v0.5/HttpServer/src/HttpServer.jl:447
app_1  |  in on_message_complete(::Ptr{HttpParser.Parser}) at /root/.julia/v0.5/HttpServer/src/RequestParser.jl:113
app_1  |  in http_parser_execute(::HttpParser.Parser, ::HttpParser.ParserSettings, ::Array{UInt8,1}) at /root/.julia/v0.5/HttpParser/src/HttpParser.jl:115
app_1  |  in process_client(::HttpServer.Server, ::HttpServer.Client{TCPSocket}, ::Bool) at /root/.julia/v0.5/HttpServer/src/HttpServer.jl:389
app_1  |  in (::HttpServer.##8#10{HttpServer.Server,Bool})() at ./task.jl:360

In any case, I'm going to kick the server over and see if that fixes anything.

@ararslan
Copy link
Member Author

ararslan commented Sep 9, 2017

If you've kicked the server, should I try invoking jlbuild again?

@staticfloat
Copy link
Member

It looks like there are unrelated testing errors with the buildbots. :/

@ViralBShah
Copy link
Member

Unrelated here, but we had at some point discussed translating the openspecfun code to Julia using @nolta 's script. That might be worth visiting once this is split off and stabilized(but obviously some non-trivial work).

@staticfloat staticfloat merged commit a5e9844 into master Sep 12, 2017
@KristofferC KristofferC deleted the aa/no-openspecfun branch September 12, 2017 16:51
vchuravy pushed a commit to JuliaPackaging/LazyArtifacts.jl that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change will break code building Build system, or building Julia or its dependencies maths Mathematical functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actually decouple special function (openspecfun) from base
4 participants