Deprecate the omission of trailing indices over non-singleton dimensions #23628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
added
arrays
mbauman
changed the title
mbauman
force-pushed
the
mb/14470-final
branch
from
fa51376 to
cad7e23
Compare
ararslan
pushed a commit
that referenced
this pull request
Sep 18, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 18, 2017
Ensure bounds are checked over trailing zero dimensions
mbauman
force-pushed
the
mb/14470-final
branch
from
cad7e23 to
d1a0879
Compare
|
I have squashed the commits down more sensibly. Once CI passes this is good to go. |
|
Failures are simply Travis Mac horribleness and #23796. |
|
|
mbauman
added a commit
that referenced
this pull request
Oct 20, 2017
In #23628, we deprecated omitting indices over dimensions that are not of length 1. Unfortunately the 0-index case got left behind. This brings it into consistency. In short, once this deprecation is removed, `A[]` will _also_ assert that there is only one element in `A`.
JeffBezanson
pushed a commit
that referenced
this pull request
Oct 23, 2017
In #23628, we deprecated omitting indices over dimensions that are not of length 1. Unfortunately the 0-index case got left behind. This brings it into consistency. In short, once this deprecation is removed, `A[]` will _also_ assert that there is only one element in `A`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step that finally closes #14770 and completes the circle on trailing indices and singleton dimensions. After this deprecation goes through, the final state of affairs will be:
1. (This is the status quo before, too.)1. (This is the part that's becoming more restrictive.)I haven't run the full test-suite yet, so I imagine there may be a few deprecations there that I've missed. And I still need to add NEWS. ButThis is, by and large, a very benign change. Very few places seem to be relying on this behavior.