Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Nullable{T} with Union{Some{T}, Void} #23642

Merged
merged 16 commits into from
Dec 15, 2017
Merged

Replace Nullable{T} with Union{Some{T}, Void} #23642

merged 16 commits into from
Dec 15, 2017
+995 −1,994

Commits on Dec 15, 2017

  1. Replace Nullable{T} with Union{Some{T}, Void}

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    0b0bc91 View commit details
    Browse the repository at this point in the history

  2. Use Union{T, Void} rather than Union{Some{T}, Void} where possible

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    605f01a View commit details
    Browse the repository at this point in the history

  3. Update precompile.jl 

    Remove all uses of Some, except for Union{Some{Any}, Void}.
    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    5c04391 View commit details
    Browse the repository at this point in the history

  4. Review fixes

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    b7cb560 View commit details
    Browse the repository at this point in the history

  5. Add coalesce() and use it

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    5db20e3 View commit details
    Browse the repository at this point in the history

  6. Fix start_worker() method definition

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    a2f1799 View commit details
    Browse the repository at this point in the history

  7. Add notnothing(x) to assert that x !== nothing 

    Use it everywhere get() was called and nothing would not trigger an error immediately.
    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    c0053f0 View commit details
    Browse the repository at this point in the history

  8. Fix ProductIterator regression by using custom MaybeValue wrapper 

    MaybeValue is just a simplified version of Nullable reserved for internal
use which wraps a value or no value in a type-stable way. Information
about whether a value is present or not is carried separately.
    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    ec91f63 View commit details
    Browse the repository at this point in the history

  9. Improve NEWS

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    c8b6193 View commit details
    Browse the repository at this point in the history

  10. Make tryparse() return Union{T, Void}

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    bfb40cf View commit details
    Browse the repository at this point in the history

  11. Improve Some, remove get(::Some[, x]) method in favor of coalesce (no… 

    …w exported)
    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    833c9ea View commit details
    Browse the repository at this point in the history

  12. LibGit2 rebase fixes

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    c8ba97a View commit details
    Browse the repository at this point in the history

  13. Test fixes

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    e44a7df View commit details
    Browse the repository at this point in the history

  14. Remove test/nullable.jl

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    1605c9d View commit details
    Browse the repository at this point in the history

  15. Fix remaining call to get() on Windows

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    e0770e5 View commit details
    Browse the repository at this point in the history

  16. Support missing in coalesce()

    @nalimilan
    nalimilan committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    55b03b1 View commit details
    Browse the repository at this point in the history