Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #17046, deprecate tic and toc #23773

Merged
merged 2 commits into from
Sep 20, 2017
Merged

fix #17046, deprecate tic and toc #23773

merged 2 commits into from
Sep 20, 2017

Conversation

JeffBezanson
Copy link
Member

Base exports roughly 9 identifiers related to timing code, which I think is quite a lot, especially when BenchmarkTools.jl offers better functionality. So I think these are pretty redundant and can be removed.

@JeffBezanson JeffBezanson added the deprecation This change introduces or involves a deprecation label Sep 19, 2017
@JeffBezanson JeffBezanson merged commit 1b02338 into master Sep 20, 2017
@JeffBezanson JeffBezanson deleted the jb/fix17046 branch September 20, 2017 15:21
@giordano
Copy link
Contributor

giordano commented Sep 21, 2017

If @belapsed from BenchmarkTools.jl worked at all in Julia master that would be useful, yes. Unfortunately, it's currently broken. (Well, besides that issue, most of the package is currently broken on Julia master.)

@KristofferC
Copy link
Member

KristofferC commented Sep 21, 2017

As a workaround, you can use

b = @benchmarkable 1+1
tune!(b)
run(b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants