more efficient repeat(Char, n) #23787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I've literally never seen any usage of this function except for ASCII chars. (Mainly, it seems to be used to create strings of spaces.) And even those uses are usually in I/O where the string-creation is not performance-critical. So I'm not sure it's worth the added complexity to make |
stevengj
reviewed
Sep 20, 2017
| @test_throws ArgumentError repeat(S, -1) | ||
| @test repeat(c, 0) == "" | ||
| @test repeat(s, 0) == "" | ||
| @test repeat(S, 0) == "" |
There was a problem hiding this comment.
Might be clearer to collapse some of these tests into a single line, e.g.
@test c^0 == s^0 == S^0 == ""
@test c^1 == s^1 == s
|
At this point it would be nice to factor out utf-8 encoding somehow --- we have several copies of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.