Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate uses of full from base/linalg/qr.jl #23835

Merged
merged 1 commit into from
Sep 25, 2017
Merged

eliminate uses of full from base/linalg/qr.jl #23835

merged 1 commit into from
Sep 25, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Sep 22, 2017

Another small step towards deprecation of full. Ref. JuliaLang/LinearAlgebra.jl#229, JuliaLang/LinearAlgebra.jl#231, #18850, and linked threads. Best!

@Sacha0 Sacha0 added the linear algebra Linear algebra label Sep 22, 2017
@Sacha0 Sacha0 added this to the 1.0 milestone Sep 22, 2017
andreasnoack
andreasnoack approved these changes Sep 24, 2017
View reviewed changes
Copy link
Member

@andreasnoack andreasnoack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit of a lie that this function is for AbstractMatrix when it explicitly uses Array in the body but that was already the case before this change. Ideally, and as in some of the other places, we should use a generic function here instead of Array.

@Sacha0 Sacha0 merged commit b2cbf31 into JuliaLang:master Sep 25, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Sep 25, 2017

Thanks all! :)

@Sacha0 Sacha0 deleted the nixfullqr branch September 25, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Sacha0 @andreasnoack