Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow non-ascii characters in printf format strings #23899

Merged
merged 3 commits into from
Sep 29, 2017
Merged

allow non-ascii characters in printf format strings #23899

merged 3 commits into from
Sep 29, 2017

Conversation

KlausC
Copy link
Contributor

@KlausC KlausC commented Sep 27, 2017 •
edited by yuyichao
Loading

Fix #23880

bkamins
bkamins reviewed Sep 27, 2017
View reviewed changes
base/printf.jl Outdated
list = []
i = j = start(s)
j1 = 0 # invariant: j1 == prevind(s, j-1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KlausC minor issue; if I understand it correctly the comment should read:

# invariant: j1 == prevind(s, j)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right!

@yuyichao yuyichao changed the title fixed issue #23880 allow non-ascii characters in printf format strings Sep 27, 2017
@yuyichao
Copy link
Contributor

Please use a more descriptive commit message and PR title. (title and top post corrected)

nalimilan
nalimilan approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkamins Good to merge?

@bkamins
Copy link
Member

bkamins commented Sep 29, 2017

@nalimilan yes

@JeffBezanson JeffBezanson merged commit 49cbf5a into JuliaLang:master Sep 29, 2017
@KlausC KlausC deleted the fix#23880 branch September 29, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KlausC @yuyichao @bkamins @nalimilan @JeffBezanson