deprecate sparse(s::UniformScaling, m::Integer) in favor of three-arg equivalent

[Sacha0]

Per triage, this pull request deprecates sparse(s::UniformScaling, m::Integer) in favor of the three-argument equivalent sparse(s::UniformScaling, m::Integer, n::Integer). Best!

[Sacha0]

Ref. #24438 (comment). Best!

[Sacha0]

Seems the deprecation somehow impacts Documenter?

[KristofferC]

Hmm, I'm seeing thousands of line of the type:

Error During Test at /home/julia/ci/worker/11rel-amd64/build/test/sparse/higherorderfns.jl:391
  Test threw an exception of type MethodError
  Expression: begin
    Q = broadcast(+, V, A, X)
    Q isa SparseMatrixCSC && Q == sparse(broadcast(+, fV, fA, fX))
end
  MethodError: no method matching sparse(::Array{Float64,2})
  Closest candidates are:
    sparse(!Matched::UniformScaling, !Matched::Integer) at deprecated.jl:55

[Sacha0]

Ah, by nature of living in Base the deprecation might be masking the sparse methods from SparseArrays. Thanks for the additional clue! :)

[fredrikekre]

Probably just need an import SparseArrays.sparse here

[Sacha0]

Yes, something of that kind should do the trick. I went with @eval SparseArrays @deprecate ...; let's see what CI says. Thanks! :)

[Sacha0]

Rebased and (hopefully) fixed the test/sparse/spqr.jl failures. Assuming CI approves and absent objections or requests for time, I plan to merge this pull request tomorrow. Best!

[Sacha0]

Thanks all! :)