Fix building tarballs without Internet access and add instructions to check it #24496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers.
…out Internet It is generally a good idea to test that final tarballs build and pass the tests. Disabling Internet access allows ensuring that builds are reproducible, and is necessary for some build servers.
|
Whoops, didn't mean to remove the label. Thanks, Milan. |
ararslan
pushed a commit
that referenced
this pull request
Nov 7, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 8, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 8, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 8, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 8, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 9, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 14, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
ararslan
pushed a commit
that referenced
this pull request
Nov 21, 2017
This file is modified by the light-source-dist target when preparing tarballs. Depending on it means that the docs will be rebuilt when calling 'make install' from the tarballs. This requires downloading files, which is problematic for replicable builds and may not be possible on build servers. Ref #24496 (cherry picked from commit bd019a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the two commit messages. This fixes #24432, restoring the behavior which was intended by #19705.
These commits should be included in the next 0.6.2 release so that Linux distributions can build packages from tarballs.