Change several methods with StridedArray args to AbstractArray (#1276) #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure doesn't look to be your fault? I'll open a new issue. |
|
Actually, I can't be sure now. It looks like it's failing to build the system image due to something in the delta between your two commits. Can you please verify locally? |
|
I think that is my fault... |
|
Hopefully, this latest change fixes the build. I forgot to run make before restarting julia. |
ViralBShah
added a commit
that referenced
this pull request
Mar 4, 2013
Change several methods with StridedArray args to AbstractArray (#1276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the "abstractified" methods were moved from array.jl to abstractarray.jl.