Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression in lowering [x... y] caused by #24538 #24552

Merged
merged 1 commit into from
Nov 9, 2017
Merged

fix regression in lowering [x... y] caused by #24538 #24552

merged 1 commit into from
Nov 9, 2017

Conversation

JeffBezanson
Copy link
Member

Recursive calls to expand-forms should generally be tail calls, matching the usual top-down macro expansion order.

@JeffBezanson
fix regression in lowering [x... y] caused by #24538
52b3c83 
recursive calls to `expand-forms` should generally be tail calls,
matching the usual top-down macro expansion order.
@JeffBezanson JeffBezanson added backport pending 0.6 bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage) labels Nov 9, 2017
@JeffBezanson
Copy link
Member Author

Not entirely recent, it turns out. On 0.6.0:

julia> Int[zeros(2)... 1]
ERROR: syntax: "..." expression outside call

@JeffBezanson JeffBezanson merged commit 27665e8 into master Nov 9, 2017
@JeffBezanson JeffBezanson deleted the jb/expand_order branch November 9, 2017 20:37
ararslan pushed a commit that referenced this pull request Nov 10, 2017
@JeffBezanson @ararslan
fix regression in lowering [x... y] caused by #24538 (#24552)
3259ae2 
recursive calls to `expand-forms` should generally be tail calls,
matching the usual top-down macro expansion order.

(cherry picked from commit 27665e8)
ararslan pushed a commit that referenced this pull request Nov 14, 2017
@JeffBezanson @ararslan
fix regression in lowering [x... y] caused by #24538 (#24552)
9d16cdc 
recursive calls to `expand-forms` should generally be tail calls,
matching the usual top-down macro expansion order.

(cherry picked from commit 27665e8)
ararslan pushed a commit that referenced this pull request Nov 21, 2017
@JeffBezanson @ararslan
fix regression in lowering [x... y] caused by #24538 (#24552)
c4d4898 
recursive calls to `expand-forms` should generally be tail calls,
matching the usual top-down macro expansion order.

(cherry picked from commit 27665e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @ararslan