Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizers take function as first argument (closes #16307) #24605

Merged
merged 8 commits into from
Nov 21, 2017
Merged

Finalizers take function as first argument (closes #16307) #24605

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b0bf9c2
=make finalizers take function as first argument
oxinabox Nov 14, 2017
747444b
=update all files so finalizers take functions as their first argument
oxinabox Nov 14, 2017
1534c38
=remove pointless type constraint
oxinabox Nov 15, 2017
687e86a
=add news for #24605
oxinabox Nov 15, 2017
1c3b17a
=spaces not tabs
oxinabox Nov 16, 2017
03ff4fb
=fix whitespacing and phrasing
oxinabox Nov 21, 2017
f94d5c9
=writing news
oxinabox Nov 21, 2017
9516d83
=writing news
oxinabox Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,13 @@ This section lists changes that do not have deprecation warnings.
* The return type of `reinterpret` has changed to `ReinterpretArray`. `reinterpret` on sparse
arrays has been discontinued.

* `Base.find_in_path` is now `Base.find_package` or `Base.find_source_file` ([#24320])
* `Base.find_in_path` is now `Base.find_package` or `Base.find_source_file` ([#24320]).

* `finalizer` now takes functions or pointers as its first argument, and the object being
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these lines have trailing whitespace, which is causing the CI failures. (It looks like we forgot to set up make check-whitespace on Circle CI.)

finalized as its second (rather than the reverse). For the majorities of uses cases this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For the majority of use cases, this change will..."

will trigger deprecation warnings. However, it will not if the 'function' is not a
subtype of `Function`, nor will it for the ambiguous cases where both arguments are
`Function`s or `Ptr{Void}`s ([#24605]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here is all funky. All should be aligned beneath the first ` before "finalizer" or it won't render properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh,
my editor has failed to detect that this is a space indented file, and so the tab key has inserted tabs.
I need to sort that out. (both in that file, and in my vim plugin configurations)


Library improvements
--------------------
Expand Down