22018: make finalizer(f, x) return x rather than nothing #24679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
approved these changes
Nov 21, 2017
|
Rebased with #24605 in. Absent objections or requests for time, I plan to merge these changes this evening (PT) or later. Best! |
Sacha0
changed the title
|
Thanks all! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
finalizer(f, x)returnxrather thannothing, addressing #22018.I found only two calls to
finalizerthat make use of the return value. Both calls are of the formislocked(...) && return finalizer(..., ...), which I've naively rewrittenislocked(...) && (finalizer(...); return nothing). Not being familiar with the associated code I cannot assess whether this rewrite is reasonable. Best!