Make test tolerance dependent on condition number in Bunch-Kaufman test #25103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
linear algebra
|
If this can help, this error can be seen on CI, with RNG seed |
rfourquet
reviewed
Dec 15, 2017
test/linalg/bunchkaufman.jl
Outdated
| @@ -19,7 +19,7 @@ a2img = randn(n,n)/2 | |||
| breal = randn(n,2)/2 | |||
| bimg = randn(n,2)/2 | |||
|
|
|||
| @testset "$eltya argument A" for eltya in (Float32, Float64, ComplexF32, ComplexF64, Int) | |||
| @testset "$eltya argument A" for eltya in (Float32, Float64, Complex64, Complex128, Int) | |||
There was a problem hiding this comment.
Slowly reverting the Complex renaming PR? 😉
andreasnoack
force-pushed
the
anj/25096
branch
from
6130eee to
3d60a9d
Compare
This was referenced Dec 15, 2017
Merged
Sacha0
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25096