Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require all arrays in eachindex to have the same axes. Fixes #13310 #25108

Merged
merged 2 commits into from
Dec 15, 2017

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 15, 2017

No description provided.

Copy link
Contributor

@strickek strickek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

328 ... have to same the same ..

NEWS.md Outdated
@@ -324,6 +324,9 @@ This section lists changes that do not have deprecation warnings.
points in reverse order; any string type overrides `reverse` to return a different
type of string must also override `reverseind` to compute reversed indices correctly.

* `eachindex(A, B...)` now requires that all inputs have the same number of elements.
When the chosen indexing is Cartesian, they have to same the same axes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"same" -> "have"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants