Fix MethodTable overwrite warning during build #25222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/methodshow.jl
Outdated
| @@ -1,5 +1,11 @@ | |||
| # This file is a part of Julia. License is MIT: https://julialang.org/license | |||
|
|
|||
| function MethodTable(m::Method) | |||
| ft = ccall(:jl_first_argument_datatype, Any, (Any,), m.sig) | |||
| ft == C_NULL && error("Method ", m, " does not correspond to a function type") | |||
There was a problem hiding this comment.
The function will return a null reference, not C_NULL, so this check doesn't work. Fortunately that shouldn't happen for any type that comes from a Method.sig field.
I also don't much like this being a constructor of MethodTable, since it doesn't construct one.
There was a problem hiding this comment.
Fair enough. I could go back to calling it get_methodtable.
timholy
force-pushed
the
teh/methodtable_warn
branch
from
a11109a
to
1b4d495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.