guard against LAPACK least squares solver test failure #25287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
bugfix
|
(AppVeyor |
test/linalg/lapack.jl
Outdated
| A = rand(elty,10,10) | ||
| B = rand(elty,10,10) | ||
| A = 10I + rand(elty, 10, 10) | ||
| B = 10I + rand(elty, 10, 10) | ||
| C, j = LAPACK.gelsd!(copy(A),copy(B)) | ||
| D, k = LAPACK.gelsy!(copy(A),copy(B)) | ||
| @test C ≈ D |
There was a problem hiding this comment.
I'd prefer to have @test C ≈ D rtol=eps(cond(A)) and continue to have some variation in the condition number of A.
Sacha0
changed the title
|
Thanks Andreas! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify a LAPACK least squares solver test to guard against chance failure due to poor conditioning of the test matrices. Failure identified by @vtjnash in https://ci.appveyor.com/project/JuliaLang/julia/build/1.0.22839/job/gam4o5u92uhi6e5j. Best!
(Did I make the test matrices too well conditioned again, Andreas? 😉)