Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter REPL backtraces on top-level scope instead of eval #25467

Closed
wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

Changes:

julia> error()
ERROR:
Stacktrace:
 [1] error() at ./error.jl:42
 [2] top-level scope

back to what it was on 0.6:

julia> error()
ERROR:
Stacktrace:
 [1] error() at ./error.jl:42

I'm not sure this is completely correct since I do not know exactly when the "top-level scope" frames appear.

cc @Keno

@yuyichao
Copy link
Contributor

yuyichao commented Jan 9, 2018

No this shouldn't be done. The toplevel scope is the repl.

@yuyichao yuyichao closed this Jan 9, 2018
@yuyichao
Copy link
Contributor

yuyichao commented Jan 9, 2018

julia> begin
       sin(1)
       error()
       end
ERROR:
Stacktrace:
 [1] error() at ./error.jl:44
 [2] top-level scope at REPL[1]:3

julia> error()
ERROR:
Stacktrace:
 [1] error() at ./error.jl:44
 [2] top-level scope

What can be done, of course, is to make sure the top-level scope in the second case also has line number.

@DilumAluthge DilumAluthge deleted the kc/no_top_level_scope_frame_repl branch March 25, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants