-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use powershell for download function for Windows #25477
Conversation
4bd5dc4
to
fa0afc2
Compare
It it worth this having a fallback to |
My understanding is that we only support windows 7+. |
relevant part of windows readme for those curious where it says that: |
I'll just merge this and we'll see how it goes. |
I think one potential problem with this might be corporate machines that have powershell disabled via group policy... I also think that Windows Nano Server doesn't ship with Powershell by default. Not sure there are enough users in any of these categories to matter, but this will probably not work everywhere. |
|
I'm very positive to have only one download function in base and use it everywhere - but I'd also like a optional hook-in mechanism such that the user might customize it for some corner cases - on clusters, in corporate environment, etc... The custom routine might ask e.g. a linux machine by ssh to download it for you to a shared storage and than copy it from that place to the destination place. |
Julia provides this hook-in mechanism by default: just replace |
Fixes #19526.