Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use powershell for download function for Windows #25477

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Conversation

JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Jan 9, 2018

Fixes #19526.

@oxinabox
Copy link
Contributor

It it worth this having a fallback to urlmon (or even to ie.exe) for purposes of making it work on Windows Vista and earlier?

@JeffBezanson
Copy link
Member Author

My understanding is that we only support windows 7+.

@pkofod
Copy link
Contributor

pkofod commented Jan 10, 2018

My understanding is that we only support windows 7+.

relevant part of windows readme for those curious where it says that:

https://github.com/JuliaLang/julia/blob/9cdd88789604096999d4b2c1935d18aee4ade895/README.windows.md#binary-distribution

@JeffBezanson
Copy link
Member Author

I'll just merge this and we'll see how it goes.

@JeffBezanson JeffBezanson merged commit 4a50e64 into master Jan 13, 2018
@JeffBezanson JeffBezanson deleted the musm-patch-6 branch January 13, 2018 05:38
@davidanthoff
Copy link
Contributor

I think one potential problem with this might be corporate machines that have powershell disabled via group policy... I also think that Windows Nano Server doesn't ship with Powershell by default. Not sure there are enough users in any of these categories to matter, but this will probably not work everywhere.

@ihnorton
Copy link
Member

ihnorton commented Mar 2, 2018

I think one potential problem with this might be corporate machines that have powershell disabled via group policy

https://stackoverflow.com/questions/49061971/is-it-possible-to-stop-julia-from-using-powershell-on-windows-7

@Petr-Hlavenka
Copy link
Contributor

I'm very positive to have only one download function in base and use it everywhere - but I'd also like a optional hook-in mechanism such that the user might customize it for some corner cases - on clusters, in corporate environment, etc... The custom routine might ask e.g. a linux machine by ssh to download it for you to a shared storage and than copy it from that place to the destination place.

@nalimilan
Copy link
Member

Julia provides this hook-in mechanism by default: just replace Base.download, and all code will use your custom version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants