Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create Accumulate iterator #25766

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
+578 −414
Open

create Accumulate iterator #25766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6278b8e
WIP: create Accumulate iterator
simonbyrne Jan 26, 2018
8bd8cae
finish revamp
simonbyrne Jan 30, 2018
7ab878e
unroll accumulate! to avoid type instability
simonbyrne Jan 31, 2018
3581f97
revert argument order change
simonbyrne Jan 31, 2018
512fbcd
fix dimension check
simonbyrne Jan 31, 2018
c5f5d47
Use destination type to determine output of cumsum! and cumprod!
simonbyrne Jan 31, 2018
a242cf6
Merge branch 'master' into sb/accumulate
simonbyrne Feb 22, 2018
2ee7db9
rejig pairwise promotion
simonbyrne Feb 24, 2018
653bf8c
Merge remote-tracking branch 'origin/master' into sb/accumulate
simonbyrne Feb 24, 2018
3594346
fix up dims
simonbyrne Feb 25, 2018
8f8581c
Merge remote-tracking branch 'origin/master' into sb/accumulate
simonbyrne Feb 25, 2018
9093387
Merge remote-tracking branch 'origin/master' into sb/accumulate
simonbyrne Feb 27, 2018
cd5d3ae
fix inplace accumulate
simonbyrne Feb 27, 2018
081d437
Merge branch 'master' into sb/accumulate
simonbyrne Feb 27, 2018
e75c623
Merge remote-tracking branch 'origin/master' into sb/accumulate
simonbyrne Feb 28, 2018
5a84b98
fix SparseArrays promotion bug
simonbyrne Feb 28, 2018
9e2b5a4
Merge branch 'master' into sb/accumulate
simonbyrne Mar 15, 2018
50ace75
fix deprecation warning
simonbyrne Mar 16, 2018
834a291
Merge remote-tracking branch 'origin/master' into sb/accumulate
simonbyrne Mar 16, 2018
5d0593a
Merge remote-tracking branch 'origin/master' into sb/accumulate
martinholters Mar 20, 2018
e47a713
Force specialization on `op` (or inlining) in `accumulate` machinery
martinholters Mar 21, 2018
9b7b8fb
Make `accumulate(..., dims=dim)` type-stable (if possible)
martinholters Mar 22, 2018
57ed1b6
Handle `dim > ndims(A)` seperately in `accumulate(op, A, dims=dim)`
martinholters Mar 22, 2018
f0c3774
Merge remote-tracking branch 'origin/master' into sb/accumulate
simonbyrne Mar 23, 2018
f0bb59d
change name of state variable in collect
simonbyrne Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,9 @@ Deprecated or removed
argument instead of defaulting to using the first dimension unless there is only
one dimension ([#24684], [#25457]).

* `cumsum` and `cumprod` have the same promotion behaviour for small integer types as `sum` and
`prod`. Use `accumulate(+, x)`/`accumulate(*,x)` to get non-promoting behaviour ([#25766]).

* The `sum_kbn` and `cumsum_kbn` functions have been moved to the
[KahanSummation](https://github.com/JuliaMath/KahanSummation.jl) package ([#24869]).

Expand Down Expand Up @@ -1402,6 +1405,7 @@ Command-line option changes
[#25725]: https://github.com/JuliaLang/julia/issues/25725
[#25745]: https://github.com/JuliaLang/julia/issues/25745
[#25763]: https://github.com/JuliaLang/julia/issues/25763
[#25766]: https://github.com/JuliaLang/julia/issues/25766
[#25786]: https://github.com/JuliaLang/julia/issues/25786
[#25812]: https://github.com/JuliaLang/julia/issues/25812
[#25815]: https://github.com/JuliaLang/julia/issues/25815
Expand Down
Loading