-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude more CI files from source distro #25906
Conversation
Also, we don't need to bundle |
Makefile
Outdated
@@ -465,7 +465,7 @@ endif | |||
|
|||
# Create file light-source-dist.tmp to hold all the filenames that go into the tarball | |||
echo "base/version_git.jl" > light-source-dist.tmp | |||
git ls-files | sed -e '/\.git/d' -e '/\.travis/d' >> light-source-dist.tmp | |||
git ls-files | sed -e '/\.git/d' -e '/\.travis/d' -e '/appveyor.yml/d' -e '/\.circleci/d' -e '/\.freebsdci/d' -e '/\.mailmap/d' >> light-source-dist.tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably just exclude everything that starts with .
, which will also get the .github
folder, then we just need to add the AppVeyor config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea how to write that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ummmm sed -e '/\.\*/d' -e '/appveyor.yml/d'
? Edit: That does not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git ls-files | sed -e '/^\..*/d' -e '/appveyor.yml/d'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iblis17 any particular reason to use .*
instead of .+
? If not, I'd suggest the latter for extra clarity (we don't mean to capture ".")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does OSX have gsed
? or I can write one for bsd sed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no gsed
, it uses BSD sed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for bsd sed
git ls-files | sed -E -e '/^\..+/d' -e '/\/\..+/d' -e '/appveyor.yml/d'
I test it on my FreeBSD box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that works! Is that compatible with GNU sed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on an Arch box, seems work.
…gnment * master: Make stdlib tests runnable standalone. (#26242) fix unary-related parsing regressions caused by #26154 (#26239) Formatting changes to new SSA IR devdocs [ci skip] use medium code model on PPC `retry` should support the check function proposed in the docstring. (#26138) mention axes in docs instead of size (#26233) exclude more CI files from source distro (#25906) Describe three-valued logic in docstrings deprecate using the value of `.=`. fixes #25954 (#26088) backport change to make CodegenPrepare work with isNoopAddrSpaceCast optimize the python version of abs2 in the microbenchmarks (#26223) Add notes for package maintainers (#25912) typo Fix broken links to functions in the manual (#26171) [NewOptimizer] Track inlining info Begin work on new optimizer framework add patch to make GC address spaces work on PPC also backport sover patch to LLVM 4.0
We already exclude travis, we should probably drop the rest as well.