-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sizehint keyword argument to IOBuffer #25944
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
767ea34
add sizehint keyword argument to IOBuffer
bicycle1885 19d9b34
use sizehint in Base
bicycle1885 f24f51d
fix NEWS.md
bicycle1885 2e3f5e8
fill PR serial [ci skip]
bicycle1885 231146d
remove redundant arguments and operations
bicycle1885 65f45fb
fixup! remove redundant arguments and operations
bicycle1885 4ee880b
check the length of arguments for safety
bicycle1885 0103483
make sizehint higer precedence than maxsize
bicycle1885 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ julia> sprint(showcompact, 66.66666) | |
``` | ||
""" | ||
function sprint(f::Function, args...; context=nothing, sizehint::Integer=0) | ||
s = IOBuffer(StringVector(sizehint), read=true, write=true) | ||
s = IOBuffer(sizehint=sizehint) | ||
# specialized version of truncate(s,0) | ||
s.size = 0 | ||
s.ptr = 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't the these three lines be deleted? |
||
|
@@ -100,7 +100,7 @@ tostr_sizehint(x::Float32) = 12 | |
|
||
function print_to_string(xs...; env=nothing) | ||
# specialized for performance reasons | ||
s = IOBuffer(StringVector(tostr_sizehint(xs[1])), read=true, write=true) | ||
s = IOBuffer(sizehint=tostr_sizehint(xs[1])) | ||
# specialized version of truncate(s,0) | ||
s.size = 0 | ||
s.ptr = 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't the these three lines be deleted? |
||
|
@@ -436,8 +436,7 @@ Returns: | |
function unindent(str::AbstractString, indent::Int; tabwidth=8) | ||
indent == 0 && return str | ||
# Note: this loses the type of the original string | ||
buf = IOBuffer(StringVector(sizeof(str)), read=true, write=true) | ||
truncate(buf,0) | ||
buf = IOBuffer(sizehint=sizeof(str)) | ||
cutting = true | ||
col = 0 # current column (0 based) | ||
for ch in str | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like
sizehint
should take precedence overmaxsize
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. consider a case where
maxsize
is 2GB (because the buffer will be sent someplace 32-bit) butsizehint
is 8. We probably don't want to allocate 2GB.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to fix that. Now fixed. Thank you.