fix AV build (#26255) #26257
Merged
fix AV build (#26255) #26257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we do something with try/catch/warn and seeing if adding in a short pause would help fix it? |
JeffBezanson
force-pushed
the
jb/rmrmdir
branch
from
511fd3d to
f9edb38
Compare
JeffBezanson
force-pushed
the
jb/rmrmdir
branch
from
f9edb38 to
6a47c19
Compare
JeffBezanson
force-pushed
the
jb/rmrmdir
branch
2 times, most recently
from
4bf68ef to
2120d7f
Compare
JeffBezanson
changed the title
|
How convenient that you could just fix the Pkg3 bug right here and get this merged quickly. What a relief not to have to go to some other repo and make a PR there, merged, then have it get backported to some branch, bump some commit here to that backported branch commit etc. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this directory is not worth having every AV run fail. Should be fixed properly, but we should unblock other testing for now.