Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few more #26670 fixes #26773

Merged
merged 1 commit into from
Apr 12, 2018
Merged

A few more #26670 fixes #26773

merged 1 commit into from
Apr 12, 2018

Conversation

simonbyrne
Copy link
Contributor

Fixes BigFloat digit rounding (JuliaIO/Formatting.jl#56). I've also tweaked the definitions to make it easier to extend to new number formats.

Fixes BigFloat digit rounding (JuliaIO/Formatting.jl#56). I've also tweaked the definitions to make it easier to extend to new number formats.
@simonbyrne simonbyrne merged commit 3666ffa into master Apr 12, 2018
@simonbyrne simonbyrne deleted the sb/signif2 branch April 12, 2018 19:02
@ararslan
Copy link
Member

This introduced a warning during the build:

WARNING: Method definition round(Real, Base.Rounding.RoundingMode{T} where T) in module Base at floatfuncs.jl:127 overwritten at floatfuncs.jl:135.

@simonbyrne
Copy link
Contributor Author

Hmm. There's not an easy way to avoid that because we are intentionally exploiting #9498, but we need to define a fallback to stop stack overflows when the method isn't defined.

@ararslan
Copy link
Member

I think @JeffBezanson worked around something like that recently?

mbauman added a commit that referenced this pull request Apr 12, 2018
* origin/master:
  A few more #26670 fixes (#26773)
  Revert "deprecate using the value of `.=`. fixes #25954" (#26754)
  change dim arguments for `diff` and `unique` to keyword args (#26776)
  reorder pmap arguments to allow do-block syntax (#26783)
  correct deprecated parametric method syntax (#26789)
  [NewOptimizer] handle new IR nodes correctly in binary format
  [NewOptimizer] support line number emission from new IR format
  fix #26453, require obviously-concrete lower bound for a var to be diagonal (#26567)
  fix #26743, spurious `return` path in try-finally in tail position (#26753)
  Also lift SelectInst addrspaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants