Get rid of the tricks to avoid overflow in the AbstractUnitRange iterator #27147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the new iterator protocol we can now iterate over a unit range in the number type of its elements, without having to worry about overflow :). Fixes #26586.
Previously iterating over say
typemin(Int8) : typemax(Int8)
was done by using anInt
internally which was converted to anInt8
each iteration. Now we can just iterate withInt8
.Something similar can probably be done for
StepRange
, but that would be another pr.