Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "upgrade of libgit2 0.27.1 (#27241)" #27493

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Conversation

staticfloat
Copy link
Sponsor Member

This reverts commit 4a303b3.

This broke the buildbots as it introduced a dependency upon libssl.so again, see discussions:

Since this broke nightlies, let's get this merged quick, then we can iterate on figuring out the solution on a feature branch. The basic test for a working fix is to build it locally, then check to see if libgit2.so has a dependency on libssl.so.

This reverts commit 4a303b3.

This broke the buildbots as it introduced a dependency upon `libssl.so`
again, see discussions:
  * #27241 (comment)
  * 4a303b3#commitcomment-29274618
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 8, 2018

introduced a dependency upon libssl.so again

Note that afaik, the issue isn't the dependence on libssl – we expect this and build a copy of it for this purpose. However, cmake can't find the right version without a patch (https://github.com/JuliaLang/julia/pull/27241/files#diff-979517b9a4ab3894b541d602a9b2d346)

@staticfloat
Copy link
Sponsor Member Author

I think you’re talking about libssh2, not libssl

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 8, 2018

Ah, right. I was confused since it also broke the (other) buildbots due to libssh2 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants