-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ARPACK and derived functions from julia repo #27616
Conversation
Also, we have not actually used the name |
fe16b66
to
0078e27
Compare
Great work guys. This has been a long time coming. Shoutout to @andreasnoack, @ViralBShah and @ararslan for chipping away at bits and pieces of this over the years. I am looking forward to a fortran-free Julia one of these days. |
Bravo! 👏 Thanks so much for taking this on, Andreas. |
Looks like you'll need --- a/test/precompile.jl
+++ b/test/precompile.jl
@@ -224,7 +224,7 @@ try
Base.PkgId(m) => Base.module_build_id(m)
end for s in
[:Base64, :CRC32c, :Dates, :DelimitedFiles, :Distributed, :FileWatching, :Markdown,
- :Future, :IterativeEigensolvers, :Libdl, :LinearAlgebra, :Logging, :Mmap, :Printf,
+ :Future, :Libdl, :LinearAlgebra, :Logging, :Mmap, :Printf,
:Profile, :Random, :Serialization, :SharedArrays, :SparseArrays, :SuiteSparse, :Test,
:Unicode, :REPL, :InteractiveUtils, :OldPkg, :Pkg, :LibGit2, :SHA, :UUIDs, :Sockets]))
@test discard_module.(deps) == deps1 |
0078e27
to
1b37147
Compare
It looks like the tests are currently failings because Documenter depends on Compat and Compat depends on |
You can just add that branch of Compat to the |
Fancy new package manager. I've tried that so let's see how it goes. |
8c8e789
to
bbaaf0e
Compare
The macOS failure is #26725 and the Circle build looks like it got OOM killed. |
Seems good to merge. |
The Compat PR should likely be merged and a new version tagged first. Otherwise there will be no Compat compatible with the latest build. |
bbaaf0e
to
f53781c
Compare
Instead, it will become a proper package, see https://github.com/JuliaLinearAlgebra/Arpack.jl, and will use binaries from https://github.com/JuliaLinearAlgebra/ArpackBuilder. This will simplify the build process of Julia a little bit.
When moving the ARPACK related functions from base to stdlib, we decided to name the package
IterativeEigensolver
to avoid using the name of the underlying library. Hence, it might seem to contradict that decision that the name of the new package isArpack
. However, the idea is to create aSparseLinearAlgebra
umbrella package that would be the right entry point for most users. TheArpack
function would mainly be a repo for hosting the actual wrapper functions.