Rename Sys.CPU_CORES => Sys.CPU_THREADS #28091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
StefanKarpinski
force-pushed
the
sk/cpu_threads
branch
from
7e5b919
to
2f3cae0
Compare
This also introduces minor functional changes to the behavior of JULIA_CPU_THREADS: when the environment variable is set but empty that is now considered to be a parse error and the default value will be used for `Sys.CPU_THREADS`; the default value when there is a parse error for JULIA_CPU_THREADS is now `jl_cpu_threads`.
StefanKarpinski
force-pushed
the
sk/cpu_threads
branch
from
2f3cae0
to
dff903e
Compare
|
Looks like this missed the environment variables in CircleCI's config. |
|
I think it is circle CI being stupid and using the config from the PR instead of the merge commit. So need to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.