Add `splitpath(p::AbstractString)` to Base.Filesystem.#28156

Merged

StefanKarpinski merged 16 commits intoJuliaLang:masterfrom NHDaly:splitpath

Sep 24, 2018

+81-1

Commits on Sep 24, 2018

Add splitpath(p::AbstractString) to Base.Filesystem.

NHDaly
authored and
StefanKarpinski
committed
switch "is root" check to ismount && remove comments since code is self-explanatory

NHDaly
authored and
StefanKarpinski
committed
Switch splitpath() to return an Array{String} instead of tuple

NHDaly
authored and
StefanKarpinski
committed
s/AbstractString/String/g

NHDaly
authored and
StefanKarpinski
committed
return type simpliication

NHDaly
authored and
StefanKarpinski
committed
realtimereview: reverse!、splitdir、[tests]

NHDaly
authored and
StefanKarpinski
committed
Attempt to add windows-focused splitpath unittests

NHDaly
authored and
StefanKarpinski
committed
Fix exports, which should make splitpath exported.

NHDaly
authored and
StefanKarpinski
committed
replace ismount with dirname(p) == p check. Also cleanup.

NHDaly
authored and
StefanKarpinski
committed
Fixed windows tests: splitpath("C:\\a")->["C:\\", "a"]

NHDaly
authored and
StefanKarpinski
committed
Added more corner-case unit tests

NHDaly
authored and
StefanKarpinski
committed
Use pushfirst! not reverse!; switch @test order

NHDaly
authored and
StefanKarpinski
committed
Added relative path C: drive tests

NHDaly
authored and
StefanKarpinski
committed
Fix relative path w/ drive ("C:a"->["C:a"]), and empty path (""->[""]).

NHDaly
authored and
StefanKarpinski
committed
Fix splitpath broken "C:\\\\a\\b" with _splitdir_nodrive.

NHDaly
authored and
StefanKarpinski
committed
Fix docstring output to fix broken doctest

NHDaly
authored and
StefanKarpinski
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `splitpath(p::AbstractString)` to Base.Filesystem.#28156

Commits on Sep 24, 2018

Add `splitpath(p::AbstractString)` to Base.Filesystem.

switch "is root" check to `ismount` && remove comments since code is self-explanatory

Switch splitpath() to return an Array{String} instead of tuple

s/AbstractString/String/g

return type simpliication

realtimereview: reverse!、splitdir、[tests]

Attempt to add windows-focused splitpath unittests

Fix exports, which should make splitpath exported.

replace `ismount` with `dirname(p) == p` check. Also cleanup.

Fixed windows tests: splitpath("C:\\a")->["C:\\", "a"]

Added more corner-case unit tests

Use pushfirst! not reverse!; switch @test order

Added relative path C: drive tests

Fix relative path w/ drive ("C:a"->["C:a"]), and empty path (""->[""]).

Fix splitpath broken "C:\\\\a\\b" with `_splitdir_nodrive`.

Fix docstring output to fix broken doctest