Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update llvmcall for new IR #28172

Merged
merged 2 commits into from
Jul 19, 2018
Merged

update llvmcall for new IR #28172

merged 2 commits into from
Jul 19, 2018

Conversation

JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Jul 18, 2018 •
edited
Loading

fixes #27694

@JeffBezanson JeffBezanson added performance Must go faster compiler:codegen Generation of LLVM IR and native code labels Jul 18, 2018
@JeffBezanson JeffBezanson changed the title update llvmcall for new IR. fixes #27694 update llvmcall for new IR Jul 18, 2018
@maleadt
Copy link
Member

maleadt commented Jul 19, 2018

Was this intended to fix #28078, being closed as a dup of #27694?
Unless I'm missing something, that MWE still fails though.

@KristofferC
Copy link
Member

Perhaps the inlining cost change to llvmcall has to be reverted as well?

@JeffBezanson
Copy link
Member Author

This does change back the inlining cost; I'll look into it.

@vchuravy
Copy link
Member

Does this also help #26297?

@JeffBezanson
Copy link
Member Author

Yes, I think it should fix that.

@Keno Keno added this to the 0.7 milestone Jul 19, 2018
@JeffBezanson JeffBezanson merged commit 9e9c4f8 into master Jul 19, 2018
@JeffBezanson JeffBezanson deleted the jb/fixllvmcall branch July 19, 2018 21:54
@tkoolen tkoolen mentioned this pull request Jul 20, 2018
Closed
tkoolen added a commit to tkoolen/FunctionWrappers.jl that referenced this pull request Jul 20, 2018
@tkoolen
Just use Base.llvmcall again now that JuliaLang/julia#28172 is fixed.
8b18539
maleadt added a commit to JuliaGPU/CUDAnative.jl that referenced this pull request Jul 27, 2018
@maleadt
Mark test unbroken again.
a77fd39 
JuliaLang/julia#28172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code performance Must go faster
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

slowdown of atomics on 0.7 / fix llvmcall
5 participants
@JeffBezanson @maleadt @KristofferC @vchuravy @Keno