-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove front-end deprecations for 1.0 #28366
Conversation
Not warning for that seems fine to me. As you said, it's more of a linting thing than correctness. |
1270c1a
to
92bd197
Compare
Another issue: after removing |
92bd197
to
29858ac
Compare
Yes, otherwise that seems like a a pretty bad trap. We could even allow it again in the future. |
cb39d36
to
15ae641
Compare
15ae641
to
649609a
Compare
649609a
to
520f0a9
Compare
Now also includes #9343, underscores as dummy variables. That can be moved to separate PR if necessary though. |
also disable "local declared twice" error This permits declaring a loop variable as local inside the loop, which was used during 0.7 to get the new scope behavior.
@JeffBezanson master's now 1.0, so this can go in as soon as you're ready and CI is passing. |
520f0a9
to
c79ede3
Compare
This may be "in the weeds," but if it's not inconvenient, it would be nice if this deprecation-removal is merged before other deprecation-removals. I have a fun developer-oriented package (will be introduced at JuliaCon) that only works reliably if the "local scope" deprecation is removed. Aficionados might want to build at the merge commit so they can make use of the package and still get the benefit of all the other deprecation warnings as they update their code to 0.7/1.0. But don't sweat over this request. |
c79ede3
to
3f8eed2
Compare
You got it, Tim :) |
This takes care of most of them.
One real problem I've found so far is that the pattern
is currently used to opt-in to the new scope behavior. However, with the new behavior turned on this gives a
local declared twice
error. We have long given this error in similar cases, e.g.let i=0; local i; end
. For now I just disabled the error, since it's pretty useless. Declaring a local twice doesn't cause any real problem and is more of a lint thing. But if we want we could be fancier and only give the error when the source code has two declarations, ignoring compiler-inserted declarations.