Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCLowering] Fix type condition to include vector of pointers #28455

Merged
merged 1 commit into from
Aug 6, 2018
Merged

[GCLowering] Fix type condition to include vector of pointers #28455

merged 1 commit into from
Aug 6, 2018

Conversation

Keno
Copy link
Member

@Keno Keno commented Aug 5, 2018

Fixes #28445

@Keno Keno added compiler:codegen Generation of LLVM IR and native code GC Garbage collector backport pending 0.7 labels Aug 5, 2018
KristofferC
KristofferC reviewed Aug 5, 2018
View reviewed changes
test/core.jl Outdated

@noinline make_foo28445() = (foo28445(1), foo28445(rand(1:10)), foo28445(rand(1:10)))
@noinline function use_tuple28445(c)
@test isa(c[2], foo28445)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab

@Keno
[GCLowering] Expand support for vectors of pointers
d242c9f 
Most of the support was already there, but it was mostly unexercised.
The recent activation of the SLP vectorizer made these patterns appear
in the IR, so fixup the support.

Fixes #28445
@Keno Keno merged commit f5a0b03 into master Aug 6, 2018
@martinholters martinholters deleted the kf/vectorcheck branch August 6, 2018 14:17
ararslan pushed a commit that referenced this pull request Aug 6, 2018
@Keno @ararslan
[GCLowering] Expand support for vectors of pointers (#28455)
0c76bfa 
Most of the support was already there, but it was mostly unexercised.
The recent activation of the SLP vectorizer made these patterns appear
in the IR, so fixup the support.

Fixes #28445

(cherry picked from commit f5a0b03)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@Keno @KristofferC
[GCLowering] Expand support for vectors of pointers (#28455)
1f76454 
Most of the support was already there, but it was mostly unexercised.
The recent activation of the SLP vectorizer made these patterns appear
in the IR, so fixup the support.

Fixes #28445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Keno @KristofferC @ararslan