Fix mix-type arithmetic detection in umin/max expansion #28465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointers can have different types. For these, a simple bitcast suffices rather than going through inttoptr. Fixes #28464
|
I also pushed this as an update to the upstream revision: https://reviews.llvm.org/D50167 |
ararslan
added
bugfix
ararslan
pushed a commit
that referenced
this pull request
Aug 6, 2018
|
Thanks Keno! :) |
|
@Keno this slipped through my todo-list and is currently not included in BB are there any patches on the horizon that I should wait for or should I push one out with this? |
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Pointers can have different types. For these, a simple bitcast suffices rather than going through inttoptr. Fixes #28464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointers can have different types. For these, a simple bitcast
suffices rather than going through inttoptr.
Fixes #28464
@Sacha0 This should fix the llvm errors you saw (you'll have to rebuild llvm to apply this)
@vchuravy Since this doesn't show up on CI at the moment, an LLVM BB bump is probably not required before this can go in, but would be good to do on short order.
Hopefully also fixes #28440 (the symptoms match at least).