Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix throw_complex_domainerror error message for log[1p] #28621

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Fix throw_complex_domainerror error message for log[1p] #28621

merged 2 commits into from
Aug 15, 2018

Conversation

garrison
Copy link
Member

This seems pretty clearly unintentional. Relevant history is in d4229be and d555a9a.

@garrison
Fix throw_complex_domainerror error message for log[1p]
ee02934 
This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.
@garrison garrison force-pushed the jrg/complex_domainerror branch from 3c905ee to ee02934 Compare August 13, 2018 02:28
@fredrikekre fredrikekre added error handling Handling of exceptions by Julia or the user backport pending 1.0 labels Aug 13, 2018
@StefanKarpinski
Copy link
Member

Would you be willing to add some tests that would have caught this?

@StefanKarpinski StefanKarpinski added the needs tests Unit tests are required for this change label Aug 14, 2018
@garrison
Copy link
Member Author

garrison commented Aug 14, 2018 •
edited
Loading

Would you be willing to add some tests that would have caught this?

The doctests would have caught this had the error not been propagated there, and they will detect any regressions now that the examples have been corrected. I can also change throw_complex_domainerror's signature to require that its first argument be a Symbol.

Is there something else you had in mind?

@JeffBezanson JeffBezanson merged commit a3a2b7a into master Aug 15, 2018
@JeffBezanson JeffBezanson deleted the jrg/complex_domainerror branch August 15, 2018 22:02
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@garrison @KristofferC
Fix throw_complex_domainerror error message for log[1p] (#28621)
8093c4b 
* Fix throw_complex_domainerror error message for log[1p]

This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.

* Require `Symbol` as first argument to `throw_complex_domainerror`

(cherry picked from commit a3a2b7a)
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@garrison @KristofferC
Fix throw_complex_domainerror error message for log[1p] (#28621)
668718c 
* Fix throw_complex_domainerror error message for log[1p]

This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.

* Require `Symbol` as first argument to `throw_complex_domainerror`

(cherry picked from commit a3a2b7a)
@KristofferC KristofferC mentioned this pull request Aug 19, 2018
Merged
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@garrison @KristofferC
Fix throw_complex_domainerror error message for log[1p] (#28621)
54f8380 
* Fix throw_complex_domainerror error message for log[1p]

This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.

* Require `Symbol` as first argument to `throw_complex_domainerror`

(cherry picked from commit a3a2b7a)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@garrison @KristofferC
Fix throw_complex_domainerror error message for log[1p] (#28621)
6a1cc66 
* Fix throw_complex_domainerror error message for log[1p]

This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.

* Require `Symbol` as first argument to `throw_complex_domainerror`

(cherry picked from commit a3a2b7a)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@garrison @KristofferC
Fix throw_complex_domainerror error message for log[1p] (#28621)
881d197 
* Fix throw_complex_domainerror error message for log[1p]

This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.

* Require `Symbol` as first argument to `throw_complex_domainerror`

(cherry picked from commit a3a2b7a)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@garrison @KristofferC
Fix throw_complex_domainerror error message for log[1p] (#28621)
f293abd 
* Fix throw_complex_domainerror error message for log[1p]

This seems pretty clearly unintentional.  Relevant history is in
d4229be and
d555a9a.

* Require `Symbol` as first argument to `throw_complex_domainerror`

(cherry picked from commit a3a2b7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
error handling Handling of exceptions by Julia or the user needs tests Unit tests are required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garrison @StefanKarpinski @fredrikekre @JeffBezanson @KristofferC