Add doctest example for broadcast! #28653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
|
Looks like we had a build timeout on OSX. Any thoughts on this? |
|
My thought is that building GCC from scratch on CI is an unwise thing to do :) |
|
@KristofferC you're paying the snarky comment review price 😛. Does the added example seem ok? |
KristofferC
approved these changes
Aug 15, 2018
base/broadcast.jl
Outdated
| ```jldoctest | ||
| julia> A = [1.0; 0.0]; | ||
|
|
||
| julia> B = [0.0; 0.0]; |
There was a problem hiding this comment.
Put A and B on the same line?
I noticed more and more that is becomes kinda annoying when the examples take too much vertical space so I try to condense as much as possible.
kshyatt
force-pushed
the
ksh/broadcastex
branch
from
b2d2676 to
8074726
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to show the different
destbehaviors.