Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to deployed docs #28710

Merged
merged 5 commits into from
Aug 17, 2018
Merged

Changes to deployed docs #28710

merged 5 commits into from
Aug 17, 2018

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Aug 16, 2018 •
edited
Loading

PR to gh-pages, see commit messages. cc @mortenpi

@fredrikekre fredrikekre added the docs This change adds or pertains to documentation label Aug 16, 2018
@mortenpi
Copy link
Contributor

Ref: #26825 (comment)

versions.js should also be updated, but otherwise LGTM.

@fredrikekre
Copy link
Member Author

versions.js should also be updated

I did this, if you scroll all the way down in the changes, or do you mean I did it incorrectly?

@mortenpi
Copy link
Contributor

Whoops, my bad. Yep, it's all good. I must have browsed the PR at a wrong commit.

@fredrikekre fredrikekre merged commit 6d690d7 into gh-pages Aug 17, 2018
@fredrikekre fredrikekre deleted the fe/gh-pages-docs branch August 17, 2018 09:52
@fredrikekre fredrikekre mentioned this pull request Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi