Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three missing gc roots in subtyping #28751

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Fix three missing gc roots in subtyping #28751

merged 1 commit into from
Aug 19, 2018

Conversation

Keno
Copy link
Member

@Keno Keno commented Aug 19, 2018

All found by static analysis. I'm hoping one of them might have
been the cause of CI failures like this one:

https://circleci.com/gh/JuliaLang/julia/33846?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@Keno Keno requested review from yuyichao and JeffBezanson August 19, 2018 01:13
@KristofferC KristofferC mentioned this pull request Aug 19, 2018
@Keno Keno merged commit 640fc09 into master Aug 19, 2018
@martinholters martinholters deleted the kf/subtyperoots branch August 19, 2018 16:31
@KristofferC KristofferC added bugfix This change fixes an existing bug and removed backport pending 1.0 labels Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants