Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ambiguity test inside a clean process #28816

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

tkf
Copy link
Member

@tkf tkf commented Aug 22, 2018

fixes #28804

# This file is a part of Julia. License is MIT: https://julialang.org/license

using Test, LinearAlgebra
@test detect_ambiguities(LinearAlgebra; imported=true, recursive=true) == []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was previously doing detect_ambiguities(LinearAlgebra, Base; ...) by accident but I suppose I didn't need Base there?

@ararslan
Copy link
Member

Looks like 32-bit Windows is hitting a GC bug:

      From worker 6:	
      From worker 6:	Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 6:	Exception: EXCEPTION_ACCESS_VIOLATION at 0x682b1f5a -- gc_try_setmark at /cygdrive/c/projects/julia/src\gc.c:1428 [inlined]
      From worker 6:	gc_mark_scan_obj8 at /cygdrive/c/projects/julia/src\gc.c:1554 [inlined]
      From worker 6:	gc_mark_loop at /cygdrive/c/projects/julia/src\gc.c:1818
      From worker 6:	in expression starting at C:\projects\julia\julia-e47bb0e211\share\julia\test\sorting.jl:35
      From worker 6:	gc_try_setmark at /cygdrive/c/projects/julia/src\gc.c:1425 [inlined]
      From worker 6:	gc_mark_scan_obj8 at /cygdrive/c/projects/julia/src\gc.c:1554 [inlined]
      From worker 6:	gc_mark_loop at /cygdrive/c/projects/julia/src\gc.c:1818

@Keno
Copy link
Member

Keno commented Aug 22, 2018

Let's watch for failures like that after merging. I'm hoping one of my recent gc root PRs may have fixed it, but wasn't picked up in this CI run yet.

@mbauman mbauman added the test This change adds or pertains to unit tests label Aug 22, 2018
@Keno Keno merged commit f31e28a into JuliaLang:master Aug 22, 2018
@KristofferC KristofferC mentioned this pull request Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test failure due to ambiguous method in ccall test
5 participants