doc: fix accumulate examples not using the init keyword #28910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
docs
KristofferC
reviewed
Aug 27, 2018
doc/src/manual/documentation.md
Outdated
| """ | ||
| ``` | ||
|
|
||
| This will create a link in the generated docs to the `accumulate` documentation | ||
| This will create a link in the generated docs to the `parse` documentation |
There was a problem hiding this comment.
"and nothing"? Also should the parse have a @ref in this sentence (it kinda shows what is described with an example then)
There was a problem hiding this comment.
I hesitated for nothing as it doesn't fall in the one the two categories below (mutating/non-mutating and similar-seeming functions), but no problem to do it. Good idea to add a ref link here too.
|
I will merge by tomorrow if no objection. |
Merged
KristofferC
pushed a commit
that referenced
this pull request
Sep 3, 2018
* doc: fix accumulate examples not using the init keyword * add links (KristofferC) (cherry picked from commit 49e58ba)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
* doc: fix accumulate examples not using the init keyword * add links (KristofferC) (cherry picked from commit 49e58ba)
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
* doc: fix accumulate examples not using the init keyword * add links (KristofferC) (cherry picked from commit 49e58ba)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* doc: fix accumulate examples not using the init keyword * add links (KristofferC) (cherry picked from commit 49e58ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced
accumulate!withtryparsein one example because it's the first fitting function I found whose docstring was actually short (compared to that ofaccumulate!).