fix bug in parsing extended colon-like operators #29314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
parser
|
It looks like there is a problem with julia> Meta.parse("a ≔ b")
:($(Expr(:≔, :a, :b)))Did we actually want to parse this as a Sorry, my bad. |
stevengj
approved these changes
Sep 22, 2018
KristofferC
pushed a commit
that referenced
this pull request
Oct 6, 2018
(cherry picked from commit 99e0b3b)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit 99e0b3b)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 99e0b3b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26262 added some operators to the
:precedence level, but the parsing code for that is a bit non-standard so they did not actually parse. This fixes it. Should be non-breaking since trying to use the operators gave an error before.