Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix perf regression from not specializing on iterate on tuples #29587

Closed
wants to merge 1 commit into from
Closed

fix perf regression from not specializing on iterate on tuples #29587

wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Oct 10, 2018 •
edited
Loading

#29133 again. The @nospecialize was put back in f93c6ef with no Nanosldier run and no reply to #29262 (comment)

@KristofferC KristofferC added the performance Must go faster label Oct 10, 2018
@vtjnash
Copy link
Member

vtjnash commented Oct 10, 2018

Need to review this again now that #28955 is merged.

@KristofferC
Copy link
Member Author

The benchmark from #29133 is currently regressed on master.

@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks("array", vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC
Copy link
Member Author

@vtjnash can I merge this now to fix the performance regression from Nanosoldier vs 1.0.3? #30218

@KristofferC KristofferC mentioned this pull request Dec 3, 2018
Closed
@vtjnash vtjnash mentioned this pull request Dec 3, 2018
Merged
@KristofferC
Copy link
Member Author

#30248

@KristofferC KristofferC closed this Dec 3, 2018
@ararslan ararslan deleted the kc/tuple_iterate_again branch December 3, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @vtjnash @nanosoldier