improve performance for sorting columns in sparse matrix (thereby improving sparse matmul) #29682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance for sparse matrix multiply (by optimizing the sorting done after the multiply is done). The two main optimizations are:
resize!
instead ofunsafe_wrap
, saves two allocations per columnPerm
object, saves at least an allocation per columnUsing the benchmarks in #29022
Before:
After
And benchmarking the code in #29022 (comment)
Before
After
cc @Alexander-Barth