Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TimeZones as scalars for broadcasting #30159

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Set TimeZones as scalars for broadcasting #30159

merged 1 commit into from
Nov 27, 2018

Conversation

iamed2
Copy link
Contributor

@iamed2 iamed2 commented Nov 26, 2018

No description provided.

@ararslan ararslan added dates Dates, times, and the Dates stdlib module stdlib Julia's standard library minor change Marginal behavior change acceptable for a minor release labels Nov 27, 2018
StefanKarpinski
StefanKarpinski approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@ararslan ararslan merged commit 6778bef into JuliaLang:master Nov 27, 2018
@ararslan ararslan deleted the ed/tz-broadcast branch November 27, 2018 21:33
@fredrikekre fredrikekre added the needs news A NEWS entry is required for this change label Nov 27, 2018
iamed2 added a commit to iamed2/julia that referenced this pull request Nov 27, 2018
@iamed2
Add news for JuliaLang#30159
cdf1170
@iamed2
Copy link
Contributor Author

iamed2 commented Nov 27, 2018

News: #30169

@fredrikekre fredrikekre removed the needs news A NEWS entry is required for this change label Nov 27, 2018
ararslan pushed a commit that referenced this pull request Nov 28, 2018
@iamed2 @ararslan
Add news for #30159 (#30169)
9c8560f
@iamed2 iamed2 mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module minor change Marginal behavior change acceptable for a minor release stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamed2 @StefanKarpinski @ararslan @fredrikekre