get(A::AbstractArray, (), default) should get A[]
#30270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and not allocate a new 0-element vector.
mbauman
added
needs decision
|
I can't imagine why whatever moron wrote that 😉 had it return an array.... |
StefanKarpinski
added
the
minor change
|
Triage approves for 1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and not allocate a new 0-element vector. I'm guessing few folks have ever looked at this method (besides to targetedly improve coverage) after it was implemented back in 2013, let alone use it. This is a breaking change that we should decide on.
I'm guessing you're not using this @timholy? (5994263)