Add a CLI help mode to show hidden opts. #30392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/help_hidden
branch
from
47faae4
to
6326130
Compare
| @@ -184,6 +188,7 @@ JL_DLLEXPORT void jl_parse_opts(int *argcp, char ***argvp) | |||
| // with the required arguments defined in base/client.jl `process_options()` | |||
| { "version", no_argument, 0, 'v' }, | |||
| { "help", no_argument, 0, 'h' }, | |||
| { "help-hidden", no_argument, 0, opt_help_hidden }, | |||
There was a problem hiding this comment.
How about calling this help-all instead? Or maybe passing --help twice?
There was a problem hiding this comment.
Same to me. -help-hidden is what LLVM uses, and I mimicked.
There was a problem hiding this comment.
I suppose matching LLVM for this does make sense.
vchuravy
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hiding internal/unstable command-line arguments (#24410, #23054), why not show them in a hidden help menu like LLVM does? I've had to look for them in the sources and explain to people that the options hadn't disappeared at least twice already (I know, nothing spectacular, but still).
We could even add an non-stability guarantee to the output and/or move some other rarely used arguments (
handle-signals,sysimage,machine-file, etc) over there to make the main help menu more clear.