Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bb-install naming conventions, add hashes #30535

Merged
merged 5 commits into from
Jan 3, 2019
Merged

Fix bb-install naming conventions, add hashes #30535

merged 5 commits into from
Jan 3, 2019

Conversation

staticfloat
Copy link
Member

@vtjnash here are the changes requested in the original bb-install PR.

@staticfloat staticfloat requested a review from vtjnash December 30, 2018 09:26
@staticfloat staticfloat added the building Build system, or building Julia or its dependencies label Dec 30, 2018
@Keno
Copy link
Member

Keno commented Dec 30, 2018

I'm using BB for wasm-compatible LLVM binaries. After the original bb-install PR, it started failing with:

/home/keno/julia-wasm2/deps/llvm.mk:523: *** multiple target patterns.  Stop.

and even with this, I get:

basename: extra operand ‘platform’
Try 'basename --help' for more information.
/home/keno/julia-wasm2/deps/llvm.mk:523: warning: overriding recipe for target '/home/keno/julia-wasm2/usr-staging/LLVM.v6.0.1.tgz'
/home/keno/julia-wasm2/deps/llvm.mk:523: warning: ignoring old recipe for target '/home/keno/julia-wasm2/usr-staging/LLVM.v6.0.1.tgz'
WARNING: sha512 checksum for srccache not found in deps/checksums/, autogenerating...
md5sum: /home/keno/julia-wasm2/deps/srccache/: Is a directory
sha512sum: /home/keno/julia-wasm2/deps/srccache/: Is a directory
sha512sum: /home/keno/julia-wasm2/deps/srccache/: Is a directory
cp: -r not specified; omitting directory '/home/keno/julia-wasm2/deps/srccache/'
/home/keno/julia-wasm2/deps/llvm.mk:523: recipe for target '/home/keno/julia-wasm2/usr-staging/LLVM.v6.0.1.tgz' failed
make[1]: *** [/home/keno/julia-wasm2/usr-staging/LLVM.v6.0.1.tgz] Error 1
Makefile:57: recipe for target 'julia-deps' failed
make: *** [julia-deps] Error 2

The relevant Make.user entries are:

USE_BINARYBUILDER_LLVM=1
BINARYBUILDER_TRIPLET=wasm32-unknown-emscripten
override LLVM_BB_URL_BASE := https://github.com/tshort/LLVMBuilder/releases/download
override LLVM_BB_REL = 0-wasm

@staticfloat
Copy link
Member Author

@Keno the meaning of the flags has changed a bit, try this instead on this branch:

$ cat Make.user
USE_BINARYBUILDER_LLVM=1
override LLVM_BB_TRIPLET := wasm32-unknown-emscripten
override LLVM_BB_URL_BASE := https://github.com/tshort/LLVMBuilder/releases/download/v6.0.1-0-wasm

@staticfloat
Copy link
Member Author

I have added windows versions of OpenBLAS v0.3.3; I had to dodge a compiler bug in AVX-512 register placement. Let's see if Appveyor is happier about that.

@staticfloat
Copy link
Member Author

Looks like it's working; we're certainly better off than we were before. There is a single failing test (SuiteSparse LU decomposition) on linux64, (mac64 and linux32 are both fine....) but I'm inclined to merge this and see if that error continues. I've restarted the linux64 build just to see if it magically disappears, but regardless I think this is ready to merge.

@vchuravy
Copy link
Member

vchuravy commented Jan 3, 2019

This only adds checksums for darwin, should we have checksums for all/any architecture? Maybe it is better to download a checksum file and use that instead?

@JeffBezanson
Copy link
Member

Anything blocking merging this to get AV back?

@staticfloat
Copy link
Member Author

I'm going to add checksums for all the architectures and then we can merge.

@staticfloat
Copy link
Member Author

Alright this is now good to go from my perspective. As soon as this returns green (the only reason it wouldn't be green is if one of the hashes that I added is wrong) let's merge it.

@staticfloat
Copy link
Member Author

That's enough green for me (excluding SuiteSparse LU factorization error). Merging.

@staticfloat staticfloat merged commit 8b189ec into master Jan 3, 2019
@StefanKarpinski StefanKarpinski deleted the sf/openblas_bb branch January 3, 2019 23:59
KristofferC pushed a commit that referenced this pull request Jan 9, 2019
@staticfloat @KristofferC
Fix bb-install naming conventions, add hashes (#30535)
8cee56d 
* Fix `bb-install` naming conventions, add hashes

* Set `DEP_LIBS` to include `openblas` on Appveyor

* When guessing BB libc, default to `glibc` on Linux

* Fix bb-install bash parsing failure

Quote to avoid bash freaking out from spurious `)` from compilers that
have fancy version strings such as `(Red Hat 7.3.1-5)`, which gets
`lastword`'ed down to `7.3.1-5)`.

* Add `contrib/refresh_bb_tarballs.sh` to aid in batch-grabbing BB hashes

(cherry picked from commit 8b189ec)
KristofferC pushed a commit that referenced this pull request Jan 11, 2019
@staticfloat @KristofferC
Fix bb-install naming conventions, add hashes (#30535)
05a8951 
* Fix `bb-install` naming conventions, add hashes

* Set `DEP_LIBS` to include `openblas` on Appveyor

* When guessing BB libc, default to `glibc` on Linux

* Fix bb-install bash parsing failure

Quote to avoid bash freaking out from spurious `)` from compilers that
have fancy version strings such as `(Red Hat 7.3.1-5)`, which gets
`lastword`'ed down to `7.3.1-5)`.

* Add `contrib/refresh_bb_tarballs.sh` to aid in batch-grabbing BB hashes

(cherry picked from commit 8b189ec)
This was referenced Jan 11, 2019
Merged
Closed
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call and removed backport 1.0 labels Jan 31, 2019
@StefanKarpinski StefanKarpinski added backport 1.0 triage This should be discussed on a triage call and removed triage This should be discussed on a triage call backport 1.0 labels Jan 31, 2019
@KristofferC
Copy link
Member

Not sure why this should go into 1.0. Removing for now.

@KristofferC KristofferC removed backport 1.0 triage This should be discussed on a triage call labels Aug 26, 2019
@StefanKarpinski
Copy link
Member

Yeah, I don't know why I added that label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@staticfloat @Keno @vchuravy @JeffBezanson @KristofferC @StefanKarpinski