Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid having a singular matrix in deserialization test for umfpack #30576

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Avoid having a singular matrix in deserialization test for umfpack #30576

merged 1 commit into from
Jan 4, 2019

Conversation

ViralBShah
Copy link
Member

Fix #30572

@ViralBShah ViralBShah added the sparse Sparse arrays label Jan 3, 2019
@ViralBShah ViralBShah mentioned this pull request Jan 3, 2019
Merged
@stevengj
Copy link
Member

stevengj commented Jan 3, 2019

Would be better to just fix the seed so that the test is deterministic

@ViralBShah
Copy link
Member Author

Added the scaled identity matrix to the random one. I think that should do the trick.

@ViralBShah ViralBShah changed the title Increase the density to avoid having a singular matrix in tests. Avoid having a singular matrix in deserialization test for umfpack Jan 3, 2019
@ViralBShah ViralBShah merged commit 4d8a968 into master Jan 4, 2019
@ViralBShah ViralBShah deleted the vs/30572 branch January 4, 2019 05:05
KristofferC pushed a commit that referenced this pull request Jan 11, 2019
@ViralBShah @KristofferC
Add the scaled identity matrix to a random matrix to avoid getting a …
d7ad4bd 
…singular matrix (#30576)

Fix #30572

(cherry picked from commit 4d8a968)
@KristofferC KristofferC mentioned this pull request Jan 11, 2019
Closed
53 tasks
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call backport 1.1 and removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call and removed triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@ViralBShah @KristofferC
Add the scaled identity matrix to a random matrix to avoid getting a …
fd9d002 
…singular matrix (#30576)

Fix #30572

(cherry picked from commit 4d8a968)
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@ViralBShah @KristofferC
Add the scaled identity matrix to a random matrix to avoid getting a …
2eed499 
…singular matrix (#30576)

Fix #30572

(cherry picked from commit 4d8a968)
@KristofferC KristofferC mentioned this pull request Feb 11, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@ViralBShah @KristofferC
Add the scaled identity matrix to a random matrix to avoid getting a …
2dc20f7 
…singular matrix (#30576)

Fix #30572

(cherry picked from commit 4d8a968)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@ViralBShah @KristofferC
Add the scaled identity matrix to a random matrix to avoid getting a …
f1a6f5d 
…singular matrix (#30576)

Fix #30572

(cherry picked from commit 4d8a968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack Awaiting requested review from andreasnoack

Assignees
No one assigned
Labels
sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SingularException in SuiteSparse tests
5 participants
@ViralBShah @stevengj @StefanKarpinski @JeffBezanson @KristofferC